Add "webtransport" request mode (integration) #1873
Conversation
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
This looks good modulo nits. One question: the WebTransport handshake doesn't have the 101 response handling?
Thanks for calling that out, no it doesn't but we probably need to break out at the same spot if mode == "webtransport" right? WebTransport does not use 101. It uses extended CONNECT, and a 2xx response establishes the session, after which the CONNECT stream is treated as the live session. |
|
If we don't expect a 101 response with WebTransport we don't have to hand control back to WebTransport when we do encounter a 101, so I think not breaking is fine. I didn't know about Extended CONNECT. |
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
How do you want to land this, land WebTransport first so you can link the connection bit?
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Add link to webtransport
|
@annevk I've merged w3c/webtransport#697 and added the link, but the link isn't working (yet?) in PR preview, or I've forgotten something. |
|
I suspect PR Preview is just on a slower update cycle of sorts. It reports a LINK ERROR which would make our CI fail and our CI doesn't fail so I think it's fine. |
2 participants
Add a "webtransport" request mode modeled on "websocket" to integrate WebTransport in a manner similar (but not identical) to WebSockets. Not exposed.
Fixes #1808.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff